On Mon, 2016-10-10 at 11:13 +0300, Andy Shevchenko wrote:
> The commit 4fe0d154880b ("PCI: Use positive flags in
> pci_alloc_irq_vectors()")
> replaces flags from negative to positive values which makes mandatory
> to have
> the last argument in pci_alloc_irq_vectors() non-zero (if we want to
> be no-op).
> This basically drops MSI enabling in 8250_lpss driver.
>
> Restore desired behaviour in 8250_lpss by passing PCI_IRQ_ALL_TYPES
> instead of
> 0 to pci_alloc_irq_vectors().
>
> Fixes: 60a9244a5d14 ("serial: 8250_lpss: enable MSI for Intel Quark")
> Cc: Christoph Hellwig <hch@xxxxxx>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> drivers/tty/serial/8250/8250_lpss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_lpss.c
> b/drivers/tty/serial/8250/8250_lpss.c
> index ac2a34e..bd8d20b 100644
> --- a/drivers/tty/serial/8250/8250_lpss.c
> +++ b/drivers/tty/serial/8250/8250_lpss.c
> @@ -216,7 +216,7 @@ static int qrk_serial_setup(struct lpss8250
> *lpss, struct uart_port *port)
> struct pci_dev *pdev = to_pci_dev(port->dev);
> int ret;
>
> - ret = pci_alloc_irq_vectors(pdev, 1, 1, 0);
> + ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
> if (ret < 0)
> return ret;
>
Looks good
Reviewed-by: Bryan O'Donoghue <pure.logic@xxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
