Re: [PATCH v1 1/1] dmaengine: hsu: refactor hsu_dma_do_irq() to return int

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 15, 2016 at 12:29:59PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Sep 14, 2016 at 06:56:52PM +0530, Vinod Koul wrote:
> > On Tue, Aug 23, 2016 at 04:09:40PM +0300, Andy Shevchenko wrote:
> > > Since we have nice macro IRQ_RETVAL() we would use it to convert a flag of
> > > handled interrupt from int to irqreturn_t.
> > > 
> > > The rationale of doing this is:
> > > a) hence we implicitly mark hsu_dma_do_irq() as an auxiliary function that
> > >    can't be used as interrupt handler directly, and
> > > b) to be in align with serial driver which is using serial8250_handle_irq()
> > >    that returns plain int by design.
> > > 
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > > ---
> > >  drivers/dma/hsu/hsu.c              | 9 ++++-----
> > >  drivers/dma/hsu/pci.c              | 6 +++---
> > >  drivers/tty/serial/8250/8250_mid.c | 8 ++++----
> > >  include/linux/dma/hsu.h            | 9 ++++-----
> > 
> > This looks okay to me but needs ACK from greg before I can apply..
> > 
> 
> Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

Applied, thanks

-- 
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux