Re: [PATCH 5/7] serial: 8250_fintek: Add F81216 Support

["Ji-Ze Hong (Peter Hong)" <hpeter@xxxxxxxxx>]

Hi Ricardo,

Ricardo Ribalda Delgado 於 2016/9/1 下午 07:22 寫道:
> >         memcpy(pdata, &probe_data, sizeof(probe_data));
> > -       uart->port.rs485_config = fintek_8250_rs485_config;
>
> Maybe just:
>
>
> if (pdata->id != CHIP_ID_F81216)
>    uart->port.rs485_config = fintek_8250_rs485_config;
>
>
> Instead of the whole function
>
> >         uart->port.private_data = pdata;
> > +       fintek_8250_set_rs485_handler(uart);
> >
> >         return 0;
> >  }

Your comments is good for this patch. But we'll still try to add more 
SuperIO with this. So we'll separate it as a function to control
individually.

--
With Best Regards,
Peter Hong
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html