Hi, > > +static unsigned long led_delay = 50; > > +module_param(led_delay, ulong, 0644); > > +MODULE_PARM_DESC(led_delay, > > + "blink delay time for activity leds (msecs, default: 50)."); > > No, no module parameter, sorry, that will not work for multiple led > devices. Thanks a lot for your feedback! I have to admit that I used drivers/net/can/led.c as an implementation base which included the blink delay configuration via module parameter. As the LED blink delay is not configurable in any other driver using led_trigger_blink_oneshot() I'd simply remove the parameter and use a constant instead. Configuration of blink delay via sysfs could be added later even though I'd prefer a more generic approach for RX/TX LED blinking within the LED subsystem in general. However that's another topic to be discussed at linux-leds ML. Do you have any other comments or objections besides the module parameter? Best regards Tobias -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
