On Mon, 2016-04-04 at 18:01 +0800,
wan.ahmad.zainie.wan.mohamad@xxxxxxxxx wrote:
> From: Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@xxxxxxxxx>
>
> Bay Trail UART port does not support DCD and DSR lines. The driver
> shall report that these signals are permanently active. This patch
> is for HSUART enumerated via PCI.
>
> For ACPI, see commit serial: 8250_dw: Fix get_mctrl behaviour.
This should be in a form
commit <12+ hash> ("<commit title>")
> The
> commit also describes the possible issue if these signals are enabled
> on a port without these pins.
>
> Signed-off-by: Wan Ahmad Zainie
> <wan.ahmad.zainie.wan.mohamad@xxxxxxxxx>
Other than above:
Acked-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> drivers/tty/serial/8250/8250_pci.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/tty/serial/8250/8250_pci.c
> b/drivers/tty/serial/8250/8250_pci.c
> index 98862aa..149f535 100644
> --- a/drivers/tty/serial/8250/8250_pci.c
> +++ b/drivers/tty/serial/8250/8250_pci.c
> @@ -1413,6 +1413,17 @@ static bool byt_dma_filter(struct dma_chan
> *chan, void *param)
> return true;
> }
>
> +static unsigned int
> +byt_get_mctrl(struct uart_port *port)
> +{
> + unsigned int ret = serial8250_do_get_mctrl(port);
> +
> + /* Force DCD and DSR signals to permanently be reported as
> active. */
> + ret |= TIOCM_CAR | TIOCM_DSR;
> +
> + return ret;
> +}
> +
> static int
> byt_serial_setup(struct serial_private *priv,
> const struct pciserial_board *board,
> @@ -1477,6 +1488,7 @@ byt_serial_setup(struct serial_private *priv,
> port->port.type = PORT_16550A;
> port->port.flags = (port->port.flags | UPF_FIXED_PORT |
> UPF_FIXED_TYPE);
> port->port.set_termios = byt_set_termios;
> + port->port.get_mctrl = byt_get_mctrl;
> port->port.fifosize = 64;
> port->tx_loadsz = 64;
> port->dma = dma;
--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
