> On Sat, Feb 13, 2016 at 10:02:34PM +0100, Maarten Brock wrote: > > > On Sat, Feb 13, 2016 at 12:11:11PM +0100, Maarten Brock wrote: > > > > Add support for manual setting and getting the modem control lines. > > > > Also fixed MSR bit definitions. > > > > And use BIT() macro. > > > > > > That's 3 different things, you need at least 3 different patches. > > > > > > Remember, a patch only does one logical thing at a time. > > > > This contradicts your response to Wills Wang at 2015-12-20 where you ask > > to combine fixing the MSR bits with changing to use the BIT() macro. It > > was this response that made me do it this way. > > If you are fixing the bit definitions, sure, use the bit macros, but > please, be sensible, if you have to say "also" or "and" in a commit > message, that's a huge flag that it needs to be split up. Searching deeper I found that the patch from Wills Wang is applied in tty-next. https://git.kernel.org/cgit/linux/kernel/git/gregkh/tty.git/log/drivers/tty/serial/sc16is7xx.c?h=tty-next I hope that means that it will make into the next stable release. This also means I don't have to send a patch to fix these bits anymore. I don't mind the current situation where all bit definitions use (1 << n) instead of BIT(n). I had the feeling you preferred BIT over << but I'm not so sure anymore. I could make a separate patch for that later if it is though. I certainly would not prefer a situation where some definitions use BIT(n) and others use (1 << n). I'll split up the patch for setting and getting now and resend them. Maarten -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
