Re: [PATCH] sc16is7xx: implemented get_mctrl / set_mctrl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Sat, Feb 13, 2016 at 12:11:11PM +0100, Maarten Brock wrote:
> > Add support for manual setting and getting the modem control lines.
> > Also fixed MSR bit definitions.
> > And use BIT() macro.
> 
> That's 3 different things, you need at least 3 different patches.
> 
> Remember, a patch only does one logical thing at a time.

This contradicts your response to Wills Wang at 2015-12-20 where you ask
to combine fixing the MSR bits with changing to use the BIT() macro. It
was this response that made me do it this way.

> 
> Please fix and resend.
> 
> thanks,
> 
> greg k-h
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux