On Sat, Feb 13, 2016 at 10:02:34PM +0100, Maarten Brock wrote: > > On Sat, Feb 13, 2016 at 12:11:11PM +0100, Maarten Brock wrote: > > > Add support for manual setting and getting the modem control lines. > > > Also fixed MSR bit definitions. > > > And use BIT() macro. > > > > That's 3 different things, you need at least 3 different patches. > > > > Remember, a patch only does one logical thing at a time. > > This contradicts your response to Wills Wang at 2015-12-20 where you ask > to combine fixing the MSR bits with changing to use the BIT() macro. It > was this response that made me do it this way. If you are fixing the bit definitions, sure, use the bit macros, but please, be sensible, if you have to say "also" or "and" in a commit message, that's a huge flag that it needs to be split up. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
