On mar., 2015-06-30 at 09:55 -0700, Greg KH wrote: > On Tue, Jun 30, 2015 at 11:05:34AM +0200, Gwenn Bourrée wrote: > > From 3b470f9cfd67ee99a6dc005915b4c86f809c8deb Mon Sep 17 00:00:00 2001 > > From: Gwenn Bourree <gwenn.bourree@xxxxxxxxx> > > Date: Mon, 29 Jun 2015 16:09:06 +0200 > > Subject: [PATCH] Add Debug define for extra levels > > Why is this here? I will take care to remove it even I don't know what happens > > > > > Improve the debug print out by adding extra debug levels > > that allow to be verbose and ease the debugging. The > > new levels macros are clearer to understand than the > > previous numbers. > > Checkpatch script resulting errors and warning have been > > solved. > > Don't do more than one thing in a single patch, otherwise it's > impossible to review, and I will reject it. Send a patch series please. OK I will submit a first patch that remove the checkpatch.pl issues then this one. > > > Signed-off-by: Gwenn Bourree <gwenn.bourree@xxxxxxxxx> > > Signed-off-by: Mustapha Ben Zoubeir <mustaphax.ben.zoubeir@xxxxxxxxx> > > Signed-off-by: Nicolas LOUIS <nicolasx.louis@xxxxxxxxx> > > Reviewed-by: Arun Ravindran <arun.ravindran@xxxxxxxxx> > > --- > > drivers/tty/n_gsm.c | 103 > > ++++++++++++++++++++++++++++++++++++---------------- > > Still linewrapped. > > And your whole email is in base64, making it impossible for me to even > edit it to fix any of these issues, if I wanted to. I don't know what to do then. I use Evolution tool to send this patch that should work with any specific settings according to https://www.kernel.org/doc/Documentation/email-clients.txt If you have any tips... > > > 1 file changed, 71 insertions(+), 32 deletions(-) > > > > diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c > > index 382d3fc..c295065 100644 > > --- a/drivers/tty/n_gsm.c > > +++ b/drivers/tty/n_gsm.c > > @@ -66,17 +66,18 @@ > > static int debug; > > module_param(debug, int, 0600); > > > > -/* Defaults: these are from the specification */ > > +#define GSMDBG_VERBOSE_PACKET_REPORT(x) ((x) & BIT(0)) > > +#define GSMDBG_FORCE_CARRIER(x) ((x) & BIT(1)) > > +#define GSMDBG_DATA_FULL_REPORT(x) ((x) & BIT(2)) > > +#define GSMDBG_DLCI_STREAM_REPORT(x) ((x) & BIT(3)) > > +#define GSMDBG_DLCI_DATA_REPORT(x) ((x) & BIT(4)) > > +#define GSMDBG_DATA_LEN_REPORT(x) ((x) & BIT(5)) > > As Marcel pointed out, don't do this, use the logging functions the > kernel already provides you (i.e. dynamic debug). The goal of this patch is really to add some other levels for debugging in this driver. These levels are selected with command in the cmdline file and they overload the pr_debug kernel printk function. What could be your advice to do this with kernel logging functions ? > > I stopped reading here. > > greg k-h Thank you Gwenn Bourree -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
