Hello Peter Could you try again the patchset? It if works for you could you send a Tested-by: Thanks! On Tue, Jun 16, 2015 at 10:28 AM, Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx> wrote: > Hello Peter > > Thanks for catching that. > > I need to fix the original patch, it is doing the assignment before the memset. > > I will resend it. > > Thanks! > > On Tue, Jun 16, 2015 at 4:30 AM, Peter Hung <hpeter@xxxxxxxxx> wrote: >> It will store SuperIO address/key with struct fintek_8250 *pdata >> in fintek_8250_probe(), but it should store in pnp_dev & "port.private_data". >> >> The fintek_8250_rs485_config() will report -EINVAL without >> this patch. >> >> This patch should following with Ricardo Ribalda Delgado >> patchsets "serial/8250_fintek Support any configuration". >> >> Signed-off-by: Peter Hung <hpeter+linux_kernel@xxxxxxxxx> >> --- >> 8250_fintek.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/8250_fintek.c b/8250_fintek.c >> index 8460fc2..b93359e 100644 >> --- a/8250_fintek.c >> +++ b/8250_fintek.c >> @@ -214,6 +214,7 @@ fintek_8250_probe(struct pnp_dev *dev, const struct pnp_device_id *dev_id) >> uart.port.flags |= UPF_SHARE_IRQ; >> uart.port.uartclk = 1843200; >> uart.port.dev = &dev->dev; >> + uart.port.private_data = pdata; >> >> pdata->key = key; >> pdata->base_port = base_port; >> -- >> 1.9.1 >> > > > > -- > Ricardo Ribalda -- Ricardo Ribalda -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
