Re: [PATCH v3 1/2] drivers/tty: refactor functions for flushing/queuing work

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/09/2015, 08:05 PM, Steven Walter wrote:
> --- a/drivers/tty/tty_port.c
> +++ b/drivers/tty/tty_port.c
> @@ -131,7 +131,7 @@ EXPORT_SYMBOL(tty_port_free_xmit_buf);
>   */
>  void tty_port_destroy(struct tty_port *port)
>  {
> -	cancel_work_sync(&port->buf.work);
> +	tty_buffer_flush_work(port);

Nack. At least n_gsm can reschedule the work from the work handler.
flush_work won't ensure the work is really dead.

regards,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux