Hi Laurent,
On Sun, Jan 4, 2015 at 11:46 PM, Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
> Hi Magnus,
>
> Thank you for the patch.
>
> On Wednesday 17 December 2014 21:53:15 Magnus Damm wrote:
>> From: Magnus Damm <damm+renesas@xxxxxxxxxxxxx>
>>
>> Add SCIFA/SCIFB pin setup code for CTS/RTS pins to handle
>> both cases of hardware flow control enabled or disabled.
>>
>> Signed-off-by: Magnus Damm <damm+renesas@xxxxxxxxxxxxx>
>> ---
>>
>> drivers/tty/serial/sh-sci.c | 60 +++++++++++++++++++++++++++++++++++++++-
>> include/linux/serial_sci.h | 2 +
>> 2 files changed, 61 insertions(+), 1 deletion(-)
>>
>> --- 0006/drivers/tty/serial/sh-sci.c
>> +++ work/drivers/tty/serial/sh-sci.c 2014-12-16 16:10:18.000000000 +0900
>> + control = serial_port_in(port, SCPCR);
>> + data = serial_port_in(port, SCPDR);
>> +
>> + if (hwflow_enabled) {
>> + control &= ~(BIT(4) | BIT(3));
>> + } else {
>> + control |= BIT(4) | BIT(3);
>
> Could you please define SCPCR_RTSC and SCPCR_CTSC macros to replace BIT(3) and
> BIT(4) ?
>
>> + data |= BIT(4);
>
> And SCPDR_RTSD here ?
Sure, that makes sense. I've included this update in V2. Sorry for
being a bit lazy in V1. =)
/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
