Re: [PATCH v2 5/6] watchdog: at91sam9: request the irq with IRQF_NO_SUSPEND

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Rafael J. Wysocki" <rafael@xxxxxxxxxx>
Subject: Re: [PATCH v2 5/6] watchdog: at91sam9: request the irq with IRQF_NO_SUSPEND
From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Date: Sat, 7 Mar 2015 10:06:21 +0100
Cc: Mark Rutland <mark.rutland@xxxxxxx>, "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx>, Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Jason Cooper <jason@xxxxxxxxxxxxxx>, Len Brown <len.brown@xxxxxxxxx>, Pavel Machek <pavel@xxxxxx>, "linux-pm@xxxxxxxxxxxxxxx" <linux-pm@xxxxxxxxxxxxxxx>, Wim Van Sebroeck <wim@xxxxxxxxx>, "linux-watchdog@xxxxxxxxxxxxxxx" <linux-watchdog@xxxxxxxxxxxxxxx>, Alessandro Zummo <a.zummo@xxxxxxxxxxxx>, "rtc-linux@xxxxxxxxxxxxxxxx" <rtc-linux@xxxxxxxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Jiri Slaby <jslaby@xxxxxxx>, "linux-serial@xxxxxxxxxxxxxxx" <linux-serial@xxxxxxxxxxxxxxx>, Mike Turquette <mturquette@xxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Nicolas Ferre <nicolas.ferre@xxxxxxxxx>, Jean-Christophe Plagniol-Villard <plagnioj@xxxxxxxxxxxx>, Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>, "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>
In-reply-to: <CAJZ5v0h8vn26BeWPVhC4e_KNhBu15-mshnbq0K=OQ1M36vPQEQ@mail.gmail.com>
User-agent: Mutt/1.5.22.1 (2013-10-16)

On Thu, Mar 05, 2015 at 04:10:16PM +0100, Rafael J. Wysocki wrote:
> enable_irq_wake() has no effect on IRQF_NO_SUSPEND interrupts, so if the
> driver uses IRQF_NO_SUSPEND, it does not need to use enable_irq_wake()
> in addition to that.

I still feel we should BUG when someone is calling enable_irq_wake() on
an irq with only one desc which has NO_SUSPEND set.


--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

References:
- [PATCH v2 0/6] ARM: at91: fix irq_pm_install_action WARNING
  - From: Boris Brezillon
- [PATCH v2 5/6] watchdog: at91sam9: request the irq with IRQF_NO_SUSPEND
  - From: Boris Brezillon
- Re: [PATCH v2 5/6] watchdog: at91sam9: request the irq with IRQF_NO_SUSPEND
  - From: Mark Rutland
- Re: [PATCH v2 5/6] watchdog: at91sam9: request the irq with IRQF_NO_SUSPEND
  - From: Rafael J. Wysocki
- Re: [PATCH v2 5/6] watchdog: at91sam9: request the irq with IRQF_NO_SUSPEND
  - From: Mark Rutland
- Re: [PATCH v2 5/6] watchdog: at91sam9: request the irq with IRQF_NO_SUSPEND
  - From: Rafael J. Wysocki

Prev by Date: Re: [RFC] With 8250 Designware UART, if writes to the LCR failed the kernel will hung up
Next by Date: Re: Misc questions about 8250_core.c
Previous by thread: Re: [PATCH v2 5/6] watchdog: at91sam9: request the irq with IRQF_NO_SUSPEND
Next by thread: Re: [PATCH v2 5/6] watchdog: at91sam9: request the irq with IRQF_NO_SUSPEND
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux PPP] [Linux FS] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Linmodem] [Device Mapper] [Linux Kernel for ARM]