> Um, you failed to change the thing I objected to, why would I want to > take the patch again? I responded saying I know it's ugly, but it's the cleanest solution I could come up with. I described the constraints that led to that solution. Prasad was waiting to see if you had any response to that before proceeding further. (Please not that I'm not thrilled with it myself; if you have an idea for a better solution, I'd be delighted to implement it.) The fundamental problem is that sometimes serial8250_rx_chars() is called from a polling loop. In that case, we cannot handle a SysRq, because the SysRq will try to invoke the same polling loop, leading to some unwanted recursion. I can't see how to solve it without a state flag. I could hide a flag in the struct uart_8250_port, but that seems worse than making the issue visible to the programmer up front. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
