Re: [PATCH 1/3] serial: pl011: Request the irq inside the probe function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 10, 2015 at 9:34 AM, Russell King - ARM Linux
<linux@xxxxxxxxxxxxxxxx> wrote:
> On Mon, Feb 09, 2015 at 07:12:17PM -0200, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
>>
>> Instead of requesting the irq in pl011_startup() and then freeing it on
>> pl011_shutdown(), we can simply request it inside the probe function, which
>> makes the code simpler as we do not need to free it.
>
> Other than that, is there a reason for this change?  Are you seeing a
> problem with the code as it stands?

I don't see any problem. Peter explained that this change would break
irq assignment with ioctl(TIOCSSERIAL), so please discard it.
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux