> I'd like to add your name to Signed-off-by as well. No problem; thanks for testing it. Signed-off-by: George Spelvin <linux@xxxxxxxxxxx> I just left it off to emphasize the patch's preliminary-and-untested nature. Out of curiosity, has anyone thought through the larger locking issues I asked about (but never figured out) when I originally posted that patch? >> Should the code instead just buffer to the flip_buffer and flip it when >> returning from serial8250_console_write? >> >> Looking at it, I'm not sure the spin_unlock is even required. >> tty_flip_buffer_push(port) >> -> tty_schedule_flip(port) >> -> schedule_work(work) >> -> queue_work(system_wq, work) >> -> queue_work_on(WORK_CPU_UNBOUND, system_wq, work) >> -> __queue_work() >> and I don't see anything that needs the port unlocked. >> >> Anyway, my suggestion to pass the flag down is illustrated in the following >> (untested) patch. Also note the emergency_situation() function, which >> ensures the logic is the same in the various locations. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
