Hi,
Thanks for your review.
2015-01-22 13:51 GMT+09:00 Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@xxxxxxxxxxx>:
> Hi,
>
> 2014-12-15 23:14 GMT+09:00 Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx>:
>> From: Hisashi Nakamura <hisashi.nakamura.ak@xxxxxxxxxxx>
>>
>> When fifo overrun happened, the interrupt status refers to
>> SCLSR register in R-Car SCIF and HSCIF.
>> Thus, overrun handling takes SCLSR register into account.
>>
>> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@xxxxxxxxxxx>
>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx>
>> ---
>>
>> This patch is based on the tty-next branch of Greg Kroah-Hartman's tty
>> tree.
>>
>> drivers/tty/serial/sh-sci.c | 18 +++++++++++++-----
>> 1 file changed, 13 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
>> index 1110523..ff549a8 100644
>> --- a/drivers/tty/serial/sh-sci.c
>> +++ b/drivers/tty/serial/sh-sci.c
>> @@ -793,8 +793,6 @@ static int sci_handle_errors(struct uart_port *port)
>> /* overrun error */
>> if (tty_insert_flip_char(tport, 0, TTY_OVERRUN))
>> copied++;
>> -
>> - dev_notice(port->dev, "overrun error\n");
>> }
>>
>> if (status & SCxSR_FER(port)) {
>> @@ -835,8 +833,6 @@ static int sci_handle_errors(struct uart_port *port)
>>
>> if (tty_insert_flip_char(tport, 0, TTY_PARITY))
>> copied++;
>> -
>> - dev_notice(port->dev, "parity error\n");
>> }
>
> I think that these fixis unrelated to support of HSCIF.
> Please split patch.
I got it.
I'll update this patch.
Thanks,
Kaneko
>
> Best regards,
> Nobuhiro
>
>
> --
> Nobuhiro Iwamatsu
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
