On Tue, Jan 13, 2015 at 08:57:48AM +0100, Geert Uytterhoeven wrote: > On Mon, Dec 15, 2014 at 3:13 PM, Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> wrote: > > From: Hisashi Nakamura <hisashi.nakamura.ak@xxxxxxxxxxx> > > > > Since the driver cannot return from overrun error if characters > > are output during overrun process, the error message of overrun > > is removed. > > > > Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@xxxxxxxxxxx> > > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> > > --- > > > > This patch is based on the tty-next branch of Greg Kroah-Hartman's tty > > tree. > > > > drivers/tty/serial/sh-sci.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c > > index fccebbd..fe2bb08 100644 > > --- a/drivers/tty/serial/sh-sci.c > > +++ b/drivers/tty/serial/sh-sci.c > > @@ -858,7 +858,6 @@ static int sci_handle_fifo_overrun(struct uart_port *port) > > tty_insert_flip_char(tport, 0, TTY_OVERRUN); > > tty_flip_buffer_push(tport); > > > > - dev_notice(port->dev, "overrun error\n"); > > copied++; > > } > > What about replacing it by a call to dev_dbg() instead? > That way it won't be printed during normal use, but depending on the > system's setting it can still be logged in syslog. > > Or do you think it's sufficient to have it in the statistics only? I like the dev_dbg() idea. Kaneko-san, could you see about respinning this patch accordingly? -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
