- Yoshihiro YUNOMAE (reason: 550 5.1.1 <yoshihiro.yunomae.ez@xxxxxxxxxxx>: Recipient address rejected: User Unknown) On 01/16/2015 11:37 AM, Michal Simek wrote: > Hi, Hi, > Origin patch looks good to me but this checking will be good to add. > Are you using of_serial.c because I didn't find any of_alias_get_id call > for 8250? I'm using of_alias_get_id() in 8250_omap.c which made it into v3.19-rc1. I think the change you mention made it one release earlier. > Your logic here is a little bit different than I have in my tree. > (Some sort of pl011 solution). You don't need to failed if you port.line is > below 0 but if you are not able to read aliases port enumeration > may be unpredictable. For omap we should have valid aliases because we have multiple UARTs. So the platform id should always be >=0 and the DT includes it already. And Tony wanted to have predicted numbers so I don't mind to fail here. Also it is nice if you have ttyS2 which maps UART2 in the manual even without having ttyS[01]. > Thanks, > Michal Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html