Re: [PATCH] serial: imx: Fix imx_flush_buffer()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andy,

On Tue, Jan 13, 2015 at 9:29 AM, fugang.duan@xxxxxxxxxxxxx
<fugang.duan@xxxxxxxxxxxxx> wrote:

>> +     /*
>> +      * UCR2_SRST will reset the transmit and receive state machines,
>> +      * all FIFOs and register USR1, USR2, UBIR, UBMR, UBRC , URXD, UTXD
> Pls remove the content "USR1, USR2, URXD, UTXD".

Actually it is better to keep this comment because this is what the
hardware does according to the manual SRST bit description in the
manual:

"Reset the transmit and receive state machines, all FIFOs and register
USR1, USR2, UBIR, UBMR,
UBRC , URXD, UTXD and UTS[6-3]."

It's true that we don't save and restore USR1, USR2, URXD, UTXD,
because we don't need to get the previous values, but the hardware
will reset them anyway, so the comment I put is correct.

Regards,

Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux