On 01/08/2015 01:15 AM, Pramod Gurav wrote:
> drivers/tty/serial/msm_serial.c | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c
> index c88b522..057008d 100644
> --- a/drivers/tty/serial/msm_serial.c
> +++ b/drivers/tty/serial/msm_serial.c
> @@ -932,27 +932,12 @@ static int __init msm_console_setup(struct console *co, char *options)
> if (unlikely(!port->membase))
> return -ENXIO;
>
> - msm_init_clock(port);
> -
Hm.. doesn't the console setup happen before the port is opened though?
I would think that we need to keep this around so that the clock is
actually enabled before we go and write to hardware registers.
> if (options)
> uart_parse_options(options, &baud, &parity, &bits, &flow);
>
> bits = 8;
> parity = 'n';
> flow = 'n';
I wonder if we should leave this here? Maybe we can rely on the user
specifying the right values on the command line?
> - msm_write(port, UART_MR2_BITS_PER_CHAR_8 | UART_MR2_STOP_BIT_LEN_ONE,
> - UART_MR2); /* 8N1 */
> -
> - if (baud < 300 || baud > 115200)
> - baud = 115200;
> - msm_set_baud_rate(port, baud);
> -
> - msm_reset(port);
> -
> - if (msm_port->is_uartdm) {
msm_port is unused now. Please remove it in the same patch.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
