Hi Peter, On 12/17/2014 08:14 PM, Peter Hurley wrote: > Hi Eric, > > On 12/17/2014 05:51 PM, Eric Nelson wrote: >> If IGNPAR/INPCK are clear in termios->c_iflag, characters >> received with parity or framing errors should be preserved >> and passed to the upper layers of the tty stack. >> >> Specifically, the decision of whether to set the character >> value to zero should be made by n_tty.c/n_tty_receive_parity_error(). >> >> Signed-off-by: Eric Nelson <eric.nelson@xxxxxxxxxxxxxxxxxxx> >> --- >> resending to add Greg Kroah-Hartman to the CC list. > > The patch should be addressed to Greg (the maintainer) and the > others cc'd. > Thanks. I was also informed off-list about scripts/get_maintainer.pl. >> >> drivers/tty/serial/imx.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c >> index 4c5e909..e892563 100644 >> --- a/drivers/tty/serial/imx.c >> +++ b/drivers/tty/serial/imx.c >> @@ -694,7 +694,7 @@ static irqreturn_t imx_rxint(int irq, void *dev_id) >> continue; >> } >> >> - rx &= sport->port.read_status_mask; >> + rx &= (sport->port.read_status_mask|0xFF); > > Space required between operator | and operands. > Oops. Checkpatch didn't catch that for me. > Also, while I was reviewing this patch, I noticed framing errors aren't > ignored by this driver with IGNPAR. Maybe roll that fix in as well? > I'll take a look at that as well for V2. Regards, Eric -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
