On Wed, Nov 12, 2014 at 05:49:01PM +0800, Chunhe Lan wrote:
> Spotted by a compile warning:
>
> drivers/tty/serial/8250/8250_core.c: In function
> 'serial8250_shutdown':
> drivers/tty/serial/8250/8250_core.c:1747:18: warning:
> 'i' may be used uninitialized in this function [-Wuninitialized]
> drivers/tty/serial/8250/8250_core.c:1725:19: note:
> 'i' was declared here
>
> Just because it annoys user.
>
> Signed-off-by: Chunhe Lan <Chunhe.Lan@xxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
> drivers/tty/serial/8250/8250_core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index 312a83f..894a357 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -1722,7 +1722,7 @@ static int serial_link_irq_chain(struct uart_8250_port *up)
>
> static void serial_unlink_irq_chain(struct uart_8250_port *up)
> {
> - struct irq_info *i;
> + struct irq_info *i = NULL;
Don't paper over gcc bugs by putting unneeded initializations in the
kernel. Try upgraging your version of gcc, I don't see this using
4.9.2.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
