Hello Janusz, On Mon, Nov 17, 2014 at 06:07:53PM +0100, Janusz Użycki wrote: > >It looks there could be one more helper useful. > >Both atmel_serial.c and mxs-auart.c checks if the line is > >supported by mctrl_gpio. > >One time it is eg.: > >(s->gpio_irq[UART_GPIO_DCD] > 0) > >another time it is eg.: > >IS_ERR_OR_NULL(mctrl_gpio_to_gpiod(s->gpios, UART_GPIO_RTS)) > > > >The first one is no possible now. The second seems rude. > >bool mctrl_gpio_is_gpio((struct mctrl_gpios *gpios, enum > >mctrl_gpio_idx gidx); > >The name is hard. Moreover the implementation could be very similar > >to mctrl_gpio_to_gpiod(). Any ideas? > > The differences: > - faster > - not exported > - used mainly in uart's interrupt > - assumes that struct mctrl_gpios *gpios exists I wonder why you need it at all?! Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
