On Fri, Sep 19, 2014 at 08:43:49AM +0100, Bryan O'Donoghue wrote: > Adds PCI identifier for the X1000 > Adds clocking and register size and register shift I would be more interested in the details about the Quart UART, like how many ports you got, maybe the clock frequency etc. then about the actual steps the you are taking in the patch. > Signed-off-by: Bryan O'Donoghue <pure.logic@xxxxxxxxxxxxxxxxx> > --- > drivers/tty/serial/8250/8250_pci.c | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c > index 61830b1..5e72959 100644 > --- a/drivers/tty/serial/8250/8250_pci.c > +++ b/drivers/tty/serial/8250/8250_pci.c > @@ -1481,6 +1481,19 @@ byt_serial_setup(struct serial_private *priv, > return ret; > } > > +#define PCI_DEVICE_ID_INTEL_QRK_UART 0x0936 > + > +static int > +pci_intel_qrk_setup(struct serial_private *priv, > + const struct pciserial_board *board, > + struct uart_8250_port *port, int idx) > +{ > + unsigned int bar, offset = board->first_offset; > + > + bar = FL_GET_BASE(board->flags); > + > + return setup_port(priv, port, bar, offset, board->reg_shift); > +} You don't need to add this. Just use pci_default_setup. Thanks, -- heikki -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html