RE: [PATCH] serial: imx: fix throttle/unthrottle callbacks for hardware assisted flow control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Pls ignore the patch.

From: Fugang Duan <b38611@xxxxxxxxxxxxx> Sent: Friday, September 19, 2014 3:17 PM
>To: gregkh@xxxxxxxxxxxxxxxxxxx
>Cc: linux-serial@xxxxxxxxxxxxxxx; Duan Fugang-B38611
>Subject: [PATCH] serial: imx: fix throttle/unthrottle callbacks for
>hardware assisted flow control
>
>From: Huang Shijie <b32955@xxxxxxxxxxxxx>
>
>From datasheet, UCR2[CTS] bit controls the 'CTS' bit and takes effort only
>when the 'CTSC' bit is negated. 'CTS' has no function when 'CTSC' is
>asserted.
>0: The CTS pin is high (inactive)
>1: The CTS pin is low (active)
>
>For throttle, it needs to clear 'CTS' and 'CTSC' bits.
>For unthrottle, it needs to enable 'CTS' and 'CTSC' bits.
>
>The patch just fix the issue.
>
>Signed-off-by: Fugang Duan  <B38611@xxxxxxxxxxxxx>
>---
> drivers/tty/serial/imx.c |    6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index
>044e86d..070a37e 100644
>--- a/drivers/tty/serial/imx.c
>+++ b/drivers/tty/serial/imx.c
>@@ -823,11 +823,9 @@ static void imx_set_mctrl(struct uart_port *port,
>unsigned int mctrl)
> 	struct imx_port *sport = (struct imx_port *)port;
> 	unsigned long temp;
>
>-	temp = readl(sport->port.membase + UCR2) & ~UCR2_CTS;
>-
>+	temp = readl(sport->port.membase + UCR2) & ~(UCR2_CTS | UCR2_CTSC);
> 	if (mctrl & TIOCM_RTS)
>-		if (!sport->dma_is_enabled)
>-			temp |= UCR2_CTS;
>+		temp |= UCR2_CTS | UCR2_CTSC;
>
> 	writel(temp, sport->port.membase + UCR2);
>
>--
>1.7.8

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux