On Mon, Apr 28, 2014 at 06:20:53PM -0500, Rob Herring wrote: > On Sat, Apr 26, 2014 at 1:19 AM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote: > > On Fri, Apr 18, 2014 at 3:19 PM, Rob Herring <robherring2@xxxxxxxxx> wrote: > >> From: Rob Herring <robh@xxxxxxxxxx> > >> > >> With the generic earlycon infrastructure in place, convert the 8250 > >> early console to use it. > >> > >> Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > >> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > >> Cc: Jiri Slaby <jslaby@xxxxxxx> > >> --- > >> drivers/tty/serial/8250/8250_early.c | 138 ++++------------------------------- > >> drivers/tty/serial/8250/Kconfig | 1 + > >> 2 files changed, 16 insertions(+), 123 deletions(-) > > > > Hi Greg, Rob > > > > This one in tty-next breaks booting: "console=uart8250,io,0x3f8,115200". > > No early console and regular console anymore. > > > > It should produce "early con and regular con". > > This is what I get for running checkpatch and converting > simple_strtoul to kstrto* which are not so equivalent. kstrto* will > not convert things such as 115200n8 to a number. > > Greg, Do you want a fix or for me to respin the series? The fix looks like this: As this is in my tree now (right?), I need a fix to apply to it. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html