Re: [PATCH] tty: xuartps: Fix build when SYSRQ is disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 17, 2013 at 03:53:14PM -0800, Sören Brinkmann wrote:
> On Tue, Dec 17, 2013 at 03:47:44PM -0800, Greg Kroah-Hartman wrote:
> > On Tue, Dec 17, 2013 at 11:27:38PM +0000, Mark Brown wrote:

> > > The sysrq field in struct uart_port is only defined when
> > > SERIAL_CORE_CONSOLE or SUPPORT_SYSRQ are selected but the driver uses
> > > the field unconditionally, causing build failures if they aren't (as
> > > happens when doing an arm64 allmodconfig).  Make the usage conditional
> > > as well.

> > Is this a 3.13-final fix, or can it wait for 3.14?

> I sent out pretty much the same fix a week ago:
> https://lkml.org/lkml/2013/12/2/694

> It seems to fix a broken build for certain configurations. Hence, I'd
> say it's a fix for 3.13.

Yeah, it's a definite build fail with an obvious fix.  You do have to go
looking for the issue and there's a simple workaround so it's not super
critical but it's definitely -final material until very late in the
cycle.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux