Re: [PATCH] tty: xuartps: Fix build when SYSRQ is disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 17, 2013 at 03:53:14PM -0800, S??ren Brinkmann wrote:
> Hi Greg, Mark,
> 
> On Tue, Dec 17, 2013 at 03:47:44PM -0800, Greg Kroah-Hartman wrote:
> > On Tue, Dec 17, 2013 at 11:27:38PM +0000, Mark Brown wrote:
> > > From: Mark Brown <broonie@xxxxxxxxxx>
> > > 
> > > The sysrq field in struct uart_port is only defined when
> > > SERIAL_CORE_CONSOLE or SUPPORT_SYSRQ are selected but the driver uses
> > > the field unconditionally, causing build failures if they aren't (as
> > > happens when doing an arm64 allmodconfig).  Make the usage conditional
> > > as well.
> > > 
> > > Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
> > > ---
> > >  drivers/tty/serial/xilinx_uartps.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > 
> > Is this a 3.13-final fix, or can it wait for 3.14?
> 
> I sent out pretty much the same fix a week ago:
> https://lkml.org/lkml/2013/12/2/694

ah, sorry, missed that one somehow.  I'll go queue this up...

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux