On Tue, Jun 4, 2013 at 1:55 AM, Lu Jingchang-B35083 <B35083@xxxxxxxxxxxxx> wrote: > From your patch of " serial: imx: Allow module build", I think the code between #ifdef CONFIG_SERIAL_IMX_CONSOLE ... #else in imx.c won't be built because the configuration is CONFIG_SERIAL_IMX_CONSOLE_MODULE now. So it is the same as if disable CONFIG_SERIAL_IMX_CONSOLE when built the driver as a module, isn't it? > On other hand, if enable CONFIG_SERIAL_X_CONSOLE option when the driver is configured as module, the build will fail with message like ERROR: "uart_console_device" [drivers/tty/serial/**.ko] undefined! Stephen Rothwel gives the solution once at url: > http://www.linuxhorizon.com/9-linux/42b33a65f64d95a2.htm > I have checked drivers/tty/serial/Kconfig to make sure that other serial drivers indeed did this way. Maybe we need to use "#if IS_ENABLED(CONFIG_SERIAL_IMX_CONSOLE)" I will resend the series tomorrow. Thanks, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
