>-----Original Message----- >From: Fabio Estevam [mailto:festevam@xxxxxxxxx] >Sent: Tuesday, June 04, 2013 10:55 AM >To: Lu Jingchang-B35083 >Cc: linux-serial@xxxxxxxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; >s.hauer@xxxxxxxxxxxxxx; shawn.guo@xxxxxxxxxx; linux-arm- >kernel@xxxxxxxxxxxxxxxxxxx >Subject: Re: [PATCH v6] tty: serial: add Freescale lpuart driver support > >On Mon, Jun 3, 2013 at 10:27 PM, Jingchang Lu <b35083@xxxxxxxxxxxxx> wrote: > >> +config SERIAL_FSL_LPUART >> + tristate "Freescale lpuart serial port support" >> + select SERIAL_CORE >> + help >> + Support for the on-chip lpuart on some Freescale SOCs. >> + >> +config SERIAL_FSL_LPUART_CONSOLE >> + bool "Console on Freescale lpuart serial port" > >It is better yo use tristate here as well. > >I have just sent the same fix for imx serial. > >Keeping it bool may lead to build error when SERIAL_FSL_LPUART=m and >SERIAL_FSL_LPUART_CONSOLE=y [Lu Jingchang-B35083] SERIAL_FSL_LPUART_CONSOLE depends on SERIAL_FSL_LPUART=y in the patch as below, when SERIAL_FSL_LPUART is configured as module, it can't be configured as console. Thanks! +config SERIAL_FSL_LPUART_CONSOLE + bool "Console on Freescale lpuart serial port" + depends on SERIAL_FSL_LPUART=y ��.n��������+%������w��{.n�����{��ǫ����{ay� ʇڙ���f���h������_�(�階�ݢj"��������G����?���&��
