Acked-off-by: Benjamin Krill <ben@xxxxxxxxxxx> On Mon, 2013-05-20 at 19:07 +0200, Lars-Peter Clausen wrote: > free_irq() expects the same pointer that was passed to request_irq(), otherwise > the IRQ is not freed. > > The issue was found using the following coccinelle script: > > <smpl> > @r1@ > type T; > T devid; > @@ > request_irq(..., devid) > > @r2@ > type r1.T; > T devid; > position p; > @@ > free_irq@p(..., devid) > > @@ > position p != r2.p; > @@ > *free_irq@p(...) > </smpl> > > Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx> > --- > drivers/tty/serial/nwpserial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/nwpserial.c b/drivers/tty/serial/nwpserial.c > index 77287c5..549c70a 100644 > --- a/drivers/tty/serial/nwpserial.c > +++ b/drivers/tty/serial/nwpserial.c > @@ -199,7 +199,7 @@ static void nwpserial_shutdown(struct uart_port *port) > dcr_write(up->dcr_host, UART_IER, up->ier); > > /* free irq */ > - free_irq(up->port.irq, port); > + free_irq(up->port.irq, up); > } > > static int nwpserial_verify_port(struct uart_port *port, -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
