> /* > + * Clear previous interrupts before installing interrupt handler > + */ > + spin_lock_irq(&uap->port.lock); > + uap->im = 0; > + writew(uap->im, uap->port.membase + UART011_IMSC); > + writew(0xffff, uap->port.membase + UART011_ICR); > + spin_unlock_irq(&uap->port.lock); I'm confused why you use spin_lock_irq before you've enabled the IRQ in the first place but looks fine. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html