On Wed, Jan 21, 2009 at 12:32:15PM +0000, Alan Cox wrote:
> > >> static struct pci_device_id serial_pci_tbl[] = {
> > >> + { PCI_VENDOR_ID_ADVANTECH, PCI_DEVICE_ID_ADVANTECH_PCI3620,
> > >> + 0x3620, PCI_ANY_ID, 0, 0,
> >
> > Why not use PCI_VENDOR_ID_ADVANTECH as PCI_SUBVENDOR_ID too?
>
> The Advantech vendor id is not 0x3620. This confused me as well which is
> why I asked for an lspci. Advantech has stuck the device id in the
> subvendor bits and '1' in the subdevice (so it should be 1 not
> PCI_ANY_ID).
is this better?
+ { PCI_VENDOR_ID_ADVANTECH, PCI_DEVICE_ID_ADVANTECH_PCI3620,
+ PCI_DEVICE_ID_ADVANTECH_PCI3620, 1, 0, 0,
Gruss
Grisu
--
Michael Bramer -- http://www.feuerwehr.kreuzau.de/wiki/
PGP: finger grisu@xxxxxxxxxxxxx -- Linux Sysadmin -- Use Debian Linux
"Wenn ich die Folgen geahnt hätte, wäre ich Uhrmacher geworden!"
--- Albert Einstein
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
