On 019, 01 19, 2009 at 11:51:22PM +0000, Michael Bramer wrote: > On Mon, Jan 19, 2009 at 05:51:01PM +0300, Andrey Panin wrote: > > On 018, 01 18, 2009 at 01:53:59PM +0000, Michael Bramer wrote: > > > Hello > > > > > > This is my first mail to this list... sorry for all my mistakes > > > > > > We use a 8-port RS-232 MIC-3620 from advantech (see > > > http://www.advantech.com/products/8-port-RS-232-Communication-CPCI-Card/mod_1-2MLG80.aspx) > > > and need linux support for this card. > > > > > > This patch add is: > > > ------------------------------------- > > > --- a/drivers/serial/8250_pci.c > > > +++ b/drivers/serial/8250_pci.c > > > @@ -768,6 +769,8 @@ > > > #define PCI_SUBDEVICE_ID_OCTPRO422 0x0208 > > > #define PCI_SUBDEVICE_ID_POCTAL232 0x0308 > > > #define PCI_SUBDEVICE_ID_POCTAL422 0x0408 > > > +#define PCI_VENDOR_ID_ADVANTECH 0x13fe > > > +#define PCI_DEVICE_ID_ADVANTECH_PCI3620 0x3620 > > > > > > /* > > > * Master list of serial port init/setup/exit quirks. > > > @@ -789,6 +792,16 @@ > > > .setup = addidata_apci7800_setup, > > > }, > > > /* > > > + * ADVANTECH > > > + */ > > > + { > > > + .vendor = PCI_VENDOR_ID_ADVANTECH, > > > + .device = PCI_DEVICE_ID_ADVANTECH_PCI3620, > > > + .subvendor = PCI_DEVICE_ID_ADVANTECH_PCI3620, > > > + .subdevice = PCI_ANY_ID, > > > + .setup = pci_default_setup, > > > + }, > > > + /* > > > * AFAVLAB cards - these may be called via parport_serial > > > * It is not clear whether this applies to all products. > > > */ > > > > This part is not needed at all, pci_default_setup() will be used by default. > > ok. I don't test this. But you are right. The last entry in > pci_serial_quirks should catch it. > > This make the patch to a 'add only 5 lines for support of 8 > Ports'-Patch. :-) > > Should I post a new patch, without this 10 lines? Yes and add Signed-off-by: line please. > BTW: there are one other card's with a part like this: > - PCI_DEVICE_ID_PLX_9030 We can safely remove it. > Gruss > Grisu > -- > Michael Bramer -- http://www.feuerwehr.kreuzau.de/wiki/ > PGP: finger grisu@xxxxxxxxxxxxx -- Linux Sysadmin -- Use Debian Linux > "Wenn ich die Folgen geahnt h?tte, w?re ich Uhrmacher geworden!" > --- Albert Einstein -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
