Re: ioremap_nocache() in setup_port() ok?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 30, 2006 at 08:57:52AM +0100, Russell King wrote:
> On Thu, Mar 30, 2006 at 12:54:10AM -0700, Grant Grundler wrote:
> > Am I correct that serial also wants _nocache() for MMIO space?
> 
> Don't know - I've always taken ioremap_nocache() as a mis-understanding
> of what ioremap() itself is supposed to do.  Indeed, if you look at
> IO-mapping.txt, ioremap_nocache() is not mentioned, and it's pretty
> clear that ioremap() is what is intended to be used to map MMIO.

I think IO-mapping.txt is stale and whoever added ioremap_nocache
failed to update it.

It would be reasonable to ignore my patch (unless you wanted
to document the expected behavior of serial) if what willy
proposed an hour ago is accepted:
	http://lkml.org/lkml/2006/3/30/251

I'll update the IO-mapping.txt based on the outcome of
willy's patch.

thanks,
grant
-
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux