Hi Russell, This patch fixes a warning in the parisc-linux.org developement tree. Helge Deller has done substantial work to enable proper ioremap() functionality in parisc port and exposed some problems with ioremap() vs ioremap_nocache() usage. Most device drivers really want ioremap_nocache(). But we've been really sloppy since most implementations treat MMIO space as uncached. Am I correct that serial also wants _nocache() for MMIO space? thanks, grant --- a/drivers/serial/8250_pci.c 13 Feb 2006 03:51:52 -0000 1.35 +++ b/drivers/serial/8250_pci.c 30 Mar 2006 07:21:03 -0000 @@ -87,7 +87,7 @@ setup_port(struct serial_private *priv, len = pci_resource_len(dev, bar); if (!priv->remapped_bar[bar]) - priv->remapped_bar[bar] = ioremap(base, len); + priv->remapped_bar[bar] = ioremap_nocache(base, len); if (!priv->remapped_bar[bar]) return -ENOMEM; - To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
