On Wed, Jan 13, 2016 at 01:14:37AM -0800, Nicholas A. Bellinger wrote: > > Yes, that's what I meant. I think it shoul be generally feasibly, but > > would require a careful audit of the !TARGET_SCF_ACK_KREF code path > > first. > > No, no, no. > > The whole point of TARGET_SCF_ACK_KREF was so the backend driver > completion path calling check_stop_free() for one ->cmd_kref, and the > fabric driver patch calling target_put_sess_cmd() for the second > ->cmd_kref both complete before attempting to free se_cmd memory. > > The hw fabric drivers that have a hard requirement for > TARGET_SCF_ACK_KREF already use it, but it wouldn't hurt to convert the > remaining ones to use it. Oh, I misread what Bart said above - I though he meant to always take the ref as well. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
