On 01/12/2016 07:20 AM, Christoph Hellwig wrote:
It also introduces SCF_ACK_KREF to determine when
transport_cmd_finish_abort() needs to drop the second
extra reference, ahead of calling target_put_sess_cmd()
for the final kref_put(&se_cmd->cmd_kref).
It would be really useful to have all drivers follow that
ACK KREF model instead of needing to deal with driver
differences everywhere..
Hello Christoph,
How about eliminating the TARGET_SCF_ACK_KREF flag ? If a command would
only be freed upon the last target_put_sess_cmd() call then I think that
the check_stop_free() callback wouldn't have to call
target_put_sess_cmd() and hence that the TARGET_SCF_ACK_KREF flag could
be removed.
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
