>From: Mike Christie [mailto:michaelc@xxxxxxxxxxx] >Sent: Friday, January 16, 2015 4:35 PM >To: Minh Duc Tran >Cc: linux-scsi@xxxxxxxxxxxxxxx; Jayamohan Kallickal >Subject: Re: [PATCH v2 1/1] be2iscsi: add block valid bit to iBFT flag >On 01/16/2015 01:44 PM, Minh Duc Tran wrote: >>> From: Michael Christie [mailto:michaelc@xxxxxxxxxxx] >>> Sent: Friday, January 16, 2015 8:28 AM >>> To: Minh Duc Tran >>> Cc: linux-scsi@xxxxxxxxxxxxxxx; Jayamohan Kallickal >>> Subject: Re: [PATCH 1/1] be2iscsi: add block valid bit to iBFT flag >> >>> I think we are misunderstanding each other on my comments. You need to modify your patch so it fixes the problem in a general way for all drivers. >> >> >> Ok got it! This is the new patch with changes for both be2iscsi and qla4xxx. >> >Could you try the attached patch. It is not even compile tested. It will allow ibft and non ibft drivers to export info in the same way. When drivers and userspace supports some of the other things like radius chap, we can add defines for those too. Compiled error with your original patch. I've changed patch with last line pasted below and compiled against the sles12 kernel for be2iscsi and qla4xxx, tested boot session with be2iscsi. It is working now. diff --git a/include/linux/iscsi_boot_sysfs.h b/include/linux/iscsi_boot_sysfs.h index 2a8b165..e120c2a 100644 --- a/include/linux/iscsi_boot_sysfs.h +++ b/include/linux/iscsi_boot_sysfs.h @@ -16,6 +16,9 @@ #ifndef _ISCSI_BOOT_SYSFS_ #define _ISCSI_BOOT_SYSFS_ +#define ISCSI_BOOT_FLAG_VALID 0x1 +#define ISCSI_BOOT_FLAG_FW_BOOT_SEL 0x2 + -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
