>From: Michael Christie [mailto:michaelc@xxxxxxxxxxx] >Sent: Friday, January 16, 2015 8:28 AM >To: Minh Duc Tran >Cc: linux-scsi@xxxxxxxxxxxxxxx; Jayamohan Kallickal >Subject: Re: [PATCH 1/1] be2iscsi: add block valid bit to iBFT flag >I think we are misunderstanding each other on my comments. You need to modify your patch so it fixes the problem in a general way for all drivers. Ok got it! This is the new patch with changes for both be2iscsi and qla4xxx. ------ Signed-off-by: Minh Tran <minh.tran@xxxxxxxxxx> --- drivers/scsi/be2iscsi/be_main.c | 4 ++-- drivers/scsi/qla4xxx/ql4_def.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index f319340..650b537 100644 --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi/be2iscsi/be_main.c @@ -429,7 +429,7 @@ static ssize_t beiscsi_show_boot_tgt_info(void *data, int type, char *buf) auth_data.chap.intr_secret); break; case ISCSI_BOOT_TGT_FLAGS: - rc = sprintf(str, "2\n"); + rc = sprintf(str, "3\n"); break; case ISCSI_BOOT_TGT_NIC_ASSOC: rc = sprintf(str, "0\n"); @@ -466,7 +466,7 @@ static ssize_t beiscsi_show_boot_eth_info(void *data, int type, char *buf) switch (type) { case ISCSI_BOOT_ETH_FLAGS: - rc = sprintf(str, "2\n"); + rc = sprintf(str, "3\n"); break; case ISCSI_BOOT_ETH_INDEX: rc = sprintf(str, "0\n"); diff --git a/drivers/scsi/qla4xxx/ql4_def.h b/drivers/scsi/qla4xxx/ql4_def.h index 8f6d0fb..ab17a2f 100644 --- a/drivers/scsi/qla4xxx/ql4_def.h +++ b/drivers/scsi/qla4xxx/ql4_def.h @@ -796,7 +796,7 @@ struct scsi_qla_host { #define CHAP_DMA_BLOCK_SIZE 512 struct workqueue_struct *task_wq; unsigned long ddb_idx_map[MAX_DDB_ENTRIES / BITS_PER_LONG]; -#define SYSFS_FLAG_FW_SEL_BOOT 2 +#define SYSFS_FLAG_FW_SEL_BOOT 3 struct iscsi_boot_kset *boot_kset; struct ql4_boot_tgt_info boot_tgt; uint16_t phy_port_num; -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
