Re: [PATCH 3/3] scsi: Remove scsi_ioctl.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/08/2015 12:35 PM, James Bottomley wrote:
On Thu, 2015-01-08 at 11:47 -0800, Andy Grover wrote:
Now that we have uapi/scsi/scsi.h, that is the logical place for SCSI ioctl
definitions to go. The kernel-specific stuff that remains is so little that
it can be folded into scsi/scsi.h, and scsi_ioctl.h removed.

Remove all scsi_ioctl.h #includes since they all also include scsi/scsi.h,
except for ide-floppy_ioctl.c where we just replace it with including
scsi/scsi.h.

What's the transition plan for userspace?  If you look at glibc
currently, it supplies both scsi.h and scsi_ioctl.h.  If we're
persuading the glibc folks to go with our versions from uapi, I think
removing a file which is an effective compile breaker for userspace is a
really bad idea.  Duplicating scsi_ioctl.h definitions in scsi.h would
also cause them problems.

I will consult with the glibc devs and see what they think, and get back to you.

Thanks -- Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux