On 12/03/2014 04:42 PM, James Bottomley wrote: > On Wed, 2014-12-03 at 16:34 +0100, Ondrej Zary wrote: >> On Wednesday 03 December 2014, Christoph Hellwig wrote: >>> Thanks for looking into this old driver. >>> >>> If you've got a few spare cycles it might make sense to simply split >>> the "wide board" support out - the driver literally is two different >>> drivers with an if/else section in every method for the totally >>> different narrow vs wide boards. Having at least a clean and simple >>> driver for the newer wide boards would be good, and narrow ones are >>> probably old enough that we can let the driver for those fade away.. >> >> I have an ASB-3940UA (bought around 2000) and use it for scanner so I can test >> patches. >> The driver was working fine so I never had to look at the code. Now I see that >> it's 12K lines long :( Converting that to something simple would require a >> lot of work. > > That's the problem: The driver as-is works in all of the use cases, so > no-one has any motivation to fix it. Plus the complexity is pretty > daunting. It's not even the worst driver we have (that prize goes to > atp870u which still has internal bus scanning code). I'm not saying > don't do the conversion, but I am saying it will have to be validated > and tested before it can go in because lots of people still seem to use > this family of devices in odd corners of the world. > It was actually on my mind, too, to split the driver up. The code for the narrow board has some issues even today (I've inserted some remarks in the code) which always get in the way when trying to update the other side. But then I only got a wide board, so I couldn't do any testing there; I was sort of banking on Matt Wilcox to have a board available ... Ondrej, if you got a narrow board I'd be willing to to the split and let you test out the result. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
