On Wed, 2014-12-03 at 16:34 +0100, Ondrej Zary wrote:
> On Wednesday 03 December 2014, Christoph Hellwig wrote:
> > Thanks for looking into this old driver.
> >
> > If you've got a few spare cycles it might make sense to simply split
> > the "wide board" support out - the driver literally is two different
> > drivers with an if/else section in every method for the totally
> > different narrow vs wide boards. Having at least a clean and simple
> > driver for the newer wide boards would be good, and narrow ones are
> > probably old enough that we can let the driver for those fade away..
>
> I have an ASB-3940UA (bought around 2000) and use it for scanner so I can test
> patches.
> The driver was working fine so I never had to look at the code. Now I see that
> it's 12K lines long :( Converting that to something simple would require a
> lot of work.
That's the problem: The driver as-is works in all of the use cases, so
no-one has any motivation to fix it. Plus the complexity is pretty
daunting. It's not even the worst driver we have (that prize goes to
atp870u which still has internal bus scanning code). I'm not saying
don't do the conversion, but I am saying it will have to be validated
and tested before it can go in because lots of people still seem to use
this family of devices in odd corners of the world.
James
��.n��������+%������w��{.n�����{������ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
