On 10/14/2013 08:30 PM, James Bottomley wrote: > On Mon, 2013-10-14 at 12:32 +0200, Hannes Reinecke wrote: [ .. ] >> >> However, there are two other patchsets pending (EH Deadline and >> asynchronous command aborts), both of which have been tested >> thoroughly _and_ have acked-by from various other parties. >> None of these patchset had received any feedback from James >> Bottomley, let alone any indication if or when they'll be merged. >> >> So I stopped sending further patchsets, sensing some communication >> breakdown on the line. > > There's no communications breakdown, I've just been very busy. EH > deadline looks OK, but let me look again to make sure. Async aborts I'm > not necessarily keen on because I know a lot of devices where aborting > just confuses the firmware more, so I think skipping aborts and moving > to LUN reset might be a better form of acceleration. > Hmm. I've made exactly the opposite experience with FC devices. A faulty SFP or wiring might cause the occasional frame drop, which will be happily corrected with an ABTS. And HBAs like lpfc or qla2xxx even have a fast command abort built into the firmware, where the firmware will not even wait for a command abort to hit the wire but rather just disable the exchange internally and return. _Not_ sending an abort but rather escalating directly to LUN reset will only make matters worse here. Plus a LUN reset won't be able to fix anything here. But sure, if there are some devices which are confused by aborts, sure we should be doing something about it. Just out of curiosity, which devices are we talking about? I would very much prefer to have inlined command aborts at least for FC, as it has proven to be really beneficial there. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@xxxxxxx +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
