>>>>> "Akinobu" == Akinobu Mita <akinobu.mita@xxxxxxxxx> writes: Akinobu> If the logical block provisioning is not enabled, map_region() Akinobu> and unmap_region() have no effect and they don't need to be Akinobu> called. Akinobu> So this makes map_region() and unmap_region() to be called only Akinobu> when scsi_debug_lbp() returns true, i.e. logical block Akinobu> provisioning is enabled. Acked-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx> Akinobu> Because scsi_debug_unmap_granularity cannot be zero with usual Akinobu> setting: scsi_debug_unmap_granularity is 1 by default, and it Akinobu> can be changed to zero with explicit module parameter setting Akinobu> only when the logical block provisioning is disabled. But it Akinobu> is only meaningful module parameter when the logical block Akinobu> provisioning is enabled. As you have found out, I generally allow module parameter values and combinations thereof that do not make strict sense. That's because the main reason for adding these parameters in the first place is to test the block and SCSI layer code that queries them. scsi_debug is a test vehicle and being able to simulate a device with broken reporting is something I use a lot. That said, I don't think we have any test scripts that actually depend on this combination of unmap parameters so I'm ok with you cleaning them up. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
