Re: [patch 1/1] sd_dif: problem with verify of type 1 protection information (PI)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>>>>> "Jeremy" == Jeremy Higdon <jeremy@xxxxxxx> writes:

Jeremy> It appears to me that there is a problem with handling of type 1
Jeremy> protection information.  It is considering a logical block
Jeremy> reference tag of 0xffffffff to be an error, but it is actually
Jeremy> valid any time ((lba & 0xffffffff) == 0xffffffff) [for example,
Jeremy> 2TiB-1, 4TiB-1, 6TiB-1, etc.].

Yes, that's a bogus check. It's actually one I put in way back to debug
a faulty device and forgot to back out. My DIF test tooling does not
rely on the block layer generate/verify functions so I never noticed.

The same issue was reported recently by Keith Busch.

Signed-off-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

-- 
Martin K. Petersen	Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux