On 03/26/2012 02:25 AM, Christoph Hellwig wrote: > On Fri, Jan 20, 2012 at 09:44:43AM -0800, Andy Grover wrote: >> On 01/20/2012 08:12 AM, Christoph Hellwig wrote: >>> On Thu, Jan 19, 2012 at 01:39:17PM -0800, Andy Grover wrote: >>>> This saves all fabrics from calling core_tmr_alloc_req() and >>>> having to check the result. The downside is se_cmd gets bigger for all >>>> requests, but hopefully later patches will reduce it. >>> >>> Without patches to void the overhead it's not acceptable. Fortunately >>> it should be doable fairly simply by using an union for command vs >>> TMR fields. >> >> This was my thought too. We should be able to move cmd variables into a >> union w/tmr struct very soon, with a low risk of introducing bugs. > > Any plans on going back to this? I'm working on a cleanup patch series that keeps getting bigger, and this will either end up in it, or I'll get to it right afterwards. -- Andy -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
