Re: [PATCH 07/13] target: Inline struct se_tmr_req into se_cmd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 20, 2012 at 09:44:43AM -0800, Andy Grover wrote:
> On 01/20/2012 08:12 AM, Christoph Hellwig wrote:
> > On Thu, Jan 19, 2012 at 01:39:17PM -0800, Andy Grover wrote:
> >> This saves all fabrics from calling core_tmr_alloc_req() and
> >> having to check the result. The downside is se_cmd gets bigger for all
> >> requests, but hopefully later patches will reduce it.
> > 
> > Without patches to void the overhead it's not acceptable. Fortunately
> > it should be doable fairly simply by using an union for command vs
> > TMR fields.
> 
> This was my thought too. We should be able to move cmd variables into a
> union w/tmr struct very soon, with a low risk of introducing bugs.

Any plans on going back to this?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux