On Wed, 2012-03-21 at 23:21 +0100, Rolf Eike Beer wrote:
> Am Dienstag 20 März 2012, 20:47:56 schrieb michaelc@xxxxxxxxxxx:
> > From: Jayamohan Kallickal <jayamohan.kallickal@xxxxxxxxxx>
> >
> > Signed-off-by: Minh Tran <MinhDuc.Tran@xxxxxxxxxx>
> > Signed-off-by: Jayamohan Kallickal <jayamohan.kallickal@xxxxxxxxxx>
> > Signed-off-by: Mike Christie <michaelc@xxxxxxxxxxx>
> > ---
> > drivers/scsi/be2iscsi/be_iscsi.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/scsi/be2iscsi/be_iscsi.c
> > b/drivers/scsi/be2iscsi/be_iscsi.c index 33c8f09..2bb681e 100644
> > --- a/drivers/scsi/be2iscsi/be_iscsi.c
> > +++ b/drivers/scsi/be2iscsi/be_iscsi.c
> > @@ -221,7 +221,7 @@ int beiscsi_ep_get_param(struct iscsi_endpoint *ep,
> > struct beiscsi_endpoint *beiscsi_ep = ep->dd_data;
> > int len = 0;
> >
> > - SE_DEBUG(DBG_LVL_8, "In beiscsi_conn_get_param, param= %d\n", param);
> > + SE_DEBUG(DBG_LVL_8, "In beiscsi_ep_get_param, param= %d\n", param);
> >
> > switch (param) {
> > case ISCSI_PARAM_CONN_PORT:
>
> What about:
>
> SE_DEBUG(DBG_LVL_8, "In %s, param= %d\n", __func__, param);
It's a matter of taste which I defer to the driver writer, but
personally I dislike the style you propose. The reason being when I see
a message I want to investigate in the kernel logs I tend to git grep
the kernel for it. In your case, I won't find it. It's far more useful
that the message be greppable than it be accurate about what function
it's actually in.
James
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
